Fix testEncodeOffsetDateTime on JDK11 #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-vertx#1014 Starting from Java 11, LocalDateTime.now() can have microseconds precision. But the test database defines the test_datetimeoffset column with scale of 5. Therefore, in order to get consistent behavior between Java 8 and Java 11, we erase the nanoOfSecond value obtained from the clock with a random number which has at most tens of microseconds precision. Signed-off-by: Thomas Segismont <[email protected]>
|
I'll merge and cherry pick |
|
Thank you @vietj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014