Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of equinox-launcher fragments in #3863

Merged

Conversation

HannesWell
Copy link
Member

Back-port of #3862

AbstractArtifactDependencyWalker

The AbstractArtifactDependencyWalker is only used to determine the
build-qualifier of of features, products and repositories and for that
should only consider what's contained in those assembly-artifacts. It
therefore should not add any special fragments to the set of considered
artifacts.

This also helps to simplify the situation for equinox-launcher fragments
for Mac, where still a special treatment for CARBON API artifacts
exists, although the  org.eclipse.equinox.launcher.carbon.macosx
artifact is not supported anymore since 2012 [1].

Required for eclipse-equinox/equinox#622

[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400
@HannesWell
Copy link
Member Author

In tycho-4 the DependencyWalker is not only used to determine the build-timestamp of a features/repo/product (as desribed in #3860 (comment)) but also to assemble the content of a deployable-feature. But since features cannot contain products and the changed code traverses products, this should not have an effect for deployable-features.

@HannesWell HannesWell enabled auto-merge (rebase) May 20, 2024 20:04
Copy link

Test Results

  591 files    591 suites   3h 52m 50s ⏱️
  412 tests   404 ✅  6 💤 1 ❌ 1 🔥
1 236 runs  1 215 ✅ 19 💤 1 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 26d0d1f.

@HannesWell HannesWell merged commit 75d1e20 into eclipse-tycho:tycho-4.0.x May 20, 2024
8 of 11 checks passed
@HannesWell HannesWell deleted the backport/tycho-4.0.x/pr-3862 branch May 21, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant