Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove equinox-launcher fragments handling in AbstractArtifactDependencyWalker #3862

Merged

Conversation

HannesWell
Copy link
Member

The AbstractArtifactDependencyWalker is only used to determine the build-qualifier of of features, products and repositories and for that should only consider what's contained in those assembly-artifacts. It therefore should not add any special fragments to the set of considered artifacts.

This also helps to simplify the situation for equinox-launcher fragments for Mac, where still a special treatment for CARBON API artifacts exists, although the org.eclipse.equinox.launcher.carbon.macosx artifact is not supported anymore since 2012 [1].

Required for eclipse-equinox/equinox#622

[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400

AbstractArtifactDependencyWalker

The AbstractArtifactDependencyWalker is only used to determine the
build-qualifier of of features, products and repositories and for that
should only consider what's contained in those assembly-artifacts. It
therefore should not add any special fragments to the set of considered
artifacts.

This also helps to simplify the situation for equinox-launcher fragments
for Mac, where still a special treatment for CARBON API artifacts
exists, although the  org.eclipse.equinox.launcher.carbon.macosx
artifact is not supported anymore since 2012 [1].

Required for eclipse-equinox/equinox#622

[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400
@HannesWell HannesWell added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label May 20, 2024
Copy link

Test Results

  594 files  ±0    594 suites  ±0   4h 6m 8s ⏱️ - 5m 19s
  422 tests ±0    413 ✅ ±0   7 💤 ±0  1 ❌ ±0  1 🔥 ±0 
1 266 runs  ±0  1 242 ✅ ±0  22 💤 ±0  1 ❌ ±0  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 3e3c38e. ± Comparison against base commit b36b02b.

@HannesWell
Copy link
Member Author

Test failures are the same as on main and unrelated.

@HannesWell HannesWell merged commit 2cdf239 into eclipse-tycho:main May 20, 2024
9 of 12 checks passed
@eclipse-tycho-bot
Copy link

💔 All backports failed

Status Branch Result
tycho-4.0.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3862

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@HannesWell HannesWell deleted the fully-equinox-launchers-handling branch May 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants