Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document): adjust document name for presentation docs #174

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jun 13, 2024

Description

Adjust the document names for presentation documents to display the credential name instead of schema.json

Why

To have a better overview of the content of the document

Issue

Refs: #166

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general but could you please clarify the milestone of #166?

@Phil91 Phil91 changed the base branch from main to release/v1.1.0-rc.1 June 17, 2024 07:03
@Phil91 Phil91 added this to the Release 1.1.0 milestone Jun 17, 2024
@Phil91 Phil91 requested a review from evegufy June 17, 2024 07:03
@Phil91 Phil91 force-pushed the bugfix/166-document-names branch from f32d3af to 4a0b5e2 Compare June 17, 2024 13:46
Copy link

sonarcloud bot commented Jun 17, 2024

@Phil91 Phil91 merged commit e10cbcb into release/v1.1.0-rc.1 Jun 17, 2024
10 checks passed
@Phil91 Phil91 deleted the bugfix/166-document-names branch June 17, 2024 14:12
Phil91 added a commit that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants