feat(osp): created new ui screens #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidhigarg-bmw
requested review from
oyo,
manojava-gk,
lavanya-bmw and
evegufy
manojava-gk
reviewed
Feb 27, 2024
| "osp": { | ||
| "heading": "Registration Summary", | ||
| "companyHeading": "Company Details", | ||
| "companyMessage": "Below you can find your company registration details shared by your onboarding provider. Please review the details and proceed to the Company Role selection below before submitting your registration.", |
There was a problem hiding this comment.
why not using translator approach here?
| @@ -0,0 +1,186 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2021, 2023 BMW Group AG | |||
| * Copyright (c) 2021, 2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
use latest template header
| @@ -0,0 +1,130 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2021, 2023 BMW Group AG | |||
| * Copyright (c) 2021, 2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
use latest template header
@manojava-gk Already checked zero linters and made these changes as well |
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
Leon-Gr
reviewed
Mar 1, 2024
|
oyo
approved these changes
Mar 4, 2024
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created new UI as per figma designs
Why
The current existing prototype implementation of the Onboarding Service Provider flow is supposed to get updated based on the final design.
Issue
#483
Checklist
Please delete options that are not relevant.