Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] VS Code missing colors #6722

Merged
merged 49 commits into from
Dec 17, 2019
Merged

[WIP] VS Code missing colors #6722

merged 49 commits into from
Dec 17, 2019

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Dec 9, 2019 •
edited by akosyakov
Loading

What it does

Registers missing VS Code colors, see https://code.visualstudio.com/api/references/theme-color

Remove old colors:

Additional (not in VSCode):

  • Dialogs
  • Menubar
  • Activity Bar borders are not applied to full height, only to tabs @jbicker
  • Preloader background: theme colors are not provided at this time
  • introduce Secondary Buttons + remove button colors from usable.css @jbicker
  • Fix: local storage runs out of memory
  • debug console tab does not have icon
  • none icon theme does not remove icons for panel widgets, terminals, output, debug console, only after clicking on them
  • detail widget tab does not have icon while drag and drop
  • some tab icons in the activity bar have wrong color, e.g. for git history and plugin views
  • in offline mode for One Dark Pro theme status bar elements are bogusly highlighted while hovering over them
  • in the right activity bar tabs are not highlighted when current (not focused) @jbicker
  • custom default dark/light Theia themes, in light theme activity bar should be light as well
  • replace debug ansi colors with terminal ansi colors
  • outline show duplicate elements

How to test

Check different themes and compare with VSCode look:

Review checklist

Reminder for reviewers

@jbicker jbicker changed the title Missing colors [WIP] Missing colors Dec 9, 2019
@akosyakov akosyakov changed the title [WIP] Missing colors [WIP] VS Code missing colors Dec 9, 2019
@akosyakov akosyakov changed the base branch from master to color_theming December 9, 2019 14:15
@akosyakov akosyakov added theming issues related to theming vscode issues related to VSCode compatibility labels Dec 9, 2019
jbicker and others added 4 commits December 9, 2019 19:52
@jbicker @akosyakov
apply base and activity bar vscode colors
53620f1 
Signed-off-by: Jan Bicker <[email protected]>
@jbicker @akosyakov
Added color variables for sidebars
a2c0b77 
and adapted regarding css files, so they make use of the new variables

Signed-off-by: Jan Bicker <[email protected]>
@akosyakov
[git] apply vscode colors
fb0aff5 
See https://code.visualstudio.com/api/references/theme-color#git-colors

`gitDecoration.ignoredResourceForeground` and `gitDecoration.submoduleResourceForeground` are ignored, since they are not supported by git extension yet.

Signed-off-by: Anton Kosyakov <[email protected]>
@jbicker @akosyakov
Added color variables for trees
a5b4792 
and adapted respecting css files by adding those variables.

Signed-off-by: Jan Bicker <[email protected]>
@akosyakov
apply panel vscode colors
9e4b294 
Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov mentioned this pull request Dec 11, 2019
Closed
@jbicker
Got rid of '--theia-ui-button-*'-Variables
0150420 
introduced defaults for secondary and disabled buttons
replaced occurrences of old variables in css with the new variables

Signed-off-by: Jan Bicker <[email protected]>
@akosyakov akosyakov force-pushed the missing_colors branch 2 times, most recently from 348c5db to 2b41fa7 Compare December 13, 2019 14:47
jbicker and others added 3 commits December 13, 2019 15:16
@jbicker
Removed old color variables for highlighted words
43b6262 
Signed-off-by: Jan Bicker <[email protected]>
@akosyakov
[theming] remove old font and icon colors
55a72b2 
Signed-off-by: Anton Kosyakov <[email protected]>
@jbicker
Removed State colors (warn, error, success, info)
a8ef69c 
introduced new variables for state backgrounds, adapted respective css.
@akosyakov akosyakov mentioned this pull request Dec 16, 2019
Merged
54 tasks
@jbicker
Improved offline behaviour of status bar.
a265d1b 
Statusbar gets an additional css class now to indicate that
theia is offline.
Introduced also additional theme variables for that case.

Signed-off-by: Jan Bicker <[email protected]>
akosyakov
akosyakov reviewed Dec 17, 2019
View reviewed changes
packages/core/src/browser/connection-status-service.ts
@@ -198,9 +198,8 @@ export class ApplicationConnectionStatusContribution extends DefaultFrontendAppl
private statusbarId = 'connection-status';

protected handleOnline(): void {
this.statusBar.setBackgroundColor(undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we introduce setHoverBackgroundColor instead of breaking APIs? We did not want to use class names in first place to limit capabilities for Theia extension developers.

akosyakov
akosyakov reviewed Dec 17, 2019
View reviewed changes
packages/core/src/browser/connection-status-service.ts
this.statusBar.removeElement(this.statusbarId);
this.statusBar.removeCls('theia-state-offline');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abbreviations are not allowed by our coding guideline: https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#whole-words-names

@akosyakov akosyakov merged commit 1b4b81c into color_theming Dec 17, 2019
@akosyakov akosyakov deleted the missing_colors branch December 17, 2019 15:49
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request Jan 20, 2020
@planger
Fix command palette CSS
115a83c 
Theia changed their CSS variables in
eclipse-theia/theia#6722.
This change adapts the variable names for the command palette.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

Assignees

@akosyakov akosyakov

@jbicker jbicker

Labels
theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbicker @akosyakov