Open VSX Registry integration #6655

jbicker · 2019-11-28T13:48:11Z

What it does

Widget where one can search and install VSCode Extensions from the Open VSX Registry.

TODO:

Out of scope:

finding a version compatible extension
detecting outdated extensions and upgrading them
supporting workspace extensions (only built-in and global (user))
supporting extension enablement
use webview to render remote content like README

How to test

Try to install/uninstall extensions. Make sure that they are preserved (or not after uninstall) on restart.
Look at the extension editor.
Test that the extension editor is opened for the vscode extension URIs.

Review checklist

as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

packages/vscode-extensions/src/browser/vscode-extensions-service.ts

svenefftinge · 2019-11-28T14:10:15Z

The items should have an 'install' button when not installed, and an 'uninstall' button when installed.

svenefftinge · 2019-11-28T14:11:52Z

The progress during installation should be shown with blue moving line above the search box, just as it does in other similar views. The button should turn to 'installing' during that.

svenefftinge · 2019-11-28T14:14:10Z

I cannot install any extension. The button spins forever.

svenefftinge · 2019-11-28T14:14:37Z

The search doesn't seem to work. If I search for 'Docker' I see many unrelated extensions.

svenefftinge · 2019-11-28T14:15:15Z

jbicker · 2019-11-28T14:24:35Z

Regarding search: theia-ide/extension-registry#3

packages/vscode-extensions/src/browser/style/extension-detail.css

akosyakov

Looked through the code:

for the detail widget open handler should handle widget options properly and uri should be aligned with VS Code. We can test with webviews like Qarkus that clicking on java extension link opens the extension widget.
generally I find naming of a package and types confusing, it should talk about registry, but looks like implementation of vscode extensions
Also old code was copied without adjustment to our current code standards.

.vscode/launch.json

packages/vscode-extensions/README.md

packages/vscode-extensions/package.json

packages/vscode-extensions/src/browser/style/extensions.svg

packages/vscode-extensions/src/browser/view/detail/vscode-extension-open-handler.ts

packages/vscode-extensions/src/browser/vscode-extensions-api.ts

packages/vscode-extensions/src/browser/vscode-extensions-contribution.ts

packages/vscode-extensions/src/browser/vscode-extensions-service.ts

packages/vscode-extensions/src/browser/view/detail/vscode-extension-open-handler.ts

akosyakov · 2019-12-12T12:17:49Z

respect extensions vscode colors, see https://code.visualstudio.com/api/references/theme-color#extensions

akosyakov · 2020-01-09T10:14:16Z

Please clean up the history: https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#checklist-commit-history There are many commits which fixes introduced by this PR. If it is hard then squash it.

packages/vsx-registry/src/browser/vsx-registry-contribution.ts

packages/vsx-registry/src/browser/vsx-registry-service.ts

Signed-off-by: Anton Kosyakov <[email protected]>

- Each plugin can be either of system or user type indicating that it was deployed by an embedding product or an end user. - System plugins are considered to be built built-in plugins. By default they are collected from `THEIA_DEFAULT_PLUGINS`, `THEIA_PLUGINS` variables or can be provided via `--plugins` cli option. - User plugins can are managed by an end user. They are stored either under user config plugins or extensions folder depending whether it is Theia plugin or VS Code extension. These plugins can survive the server restart. Signed-off-by: Anton Kosyakov <[email protected]>

…ode Marketplace Since it's violates MS TOS which allows only access only for products of the VS Code family. Theia based products has to provide own resolution. Signed-off-by: Anton Kosyakov <[email protected]>

Signed-off-by: Anton Kosyakov <[email protected]>

…and started Signed-off-by: Anton Kosyakov <[email protected]>

Signed-off-by: Anton Kosyakov <[email protected]>

akosyakov · 2020-03-13T16:23:59Z

I've rebased and addressed all comments from @vince-fugnitto and @spoenemann.

The current state:

@marcdumais-work @svenefftinge please have a look

vince-fugnitto

I did another review pass and concluded with the following findings:

verified that any new dependencies have approved licenses
verified superficially the source code and could not identify any major issues
verified that builtin extensions were correctly listed, and could not be removed

Past Issues:

previous issues with icons (ex: gulp) has been successfully addressed
the min height for the tree-view is successfully addressed

Issues:

the search does not work properly (ex: search for 'a' yields not results but 'alt' does)
when the progress bar is shown, there is a minor UI glitch where the rest of the view is pushed down
an extension's readme should be displayed in the center, similarly to vscode (tested using editorconfig)

Improvements (now or in the future):

better display of individual extensions in the tree (an extension's name should be bold like in vscode and less padding with the publisher):

akosyakov · 2020-03-18T08:03:52Z

the search does not work properly (ex: search for 'a' yields not results but 'alt' does)

@vince-fugnitto I've filed an issue for the registry: eclipse/openvsx#34 cc @spoenemann

I'm not sure about other issues, they seem to be minor. I would better invest time into integration tests for typescript againt new Monaco. Someone else can improve styling after this PR is merged.

akosyakov · 2020-03-18T10:41:11Z

I'm going to merge it tomorrow if no objection. Theia 1.0 is already next week.

vince-fugnitto · 2020-03-18T12:19:13Z

the search does not work properly (ex: search for 'a' yields not results but 'alt' does)

@vince-fugnitto I've filed an issue for the registry: eclipse/openvsx#34 cc @spoenemann

👍

I'm not sure about other issues, they seem to be minor. I would better invest time into integration tests for typescript againt new Monaco. Someone else can improve styling after this PR is merged.

I'm fine with that, the improvements can be made iteratively at a later point.
I'll file issues for them once the pull-request is merged.

vince-fugnitto · 2020-03-19T12:59:22Z

With the VSX (Extension) view now merged, is there still a reason to have the Plugins view?

svenefftinge reviewed Nov 28, 2019

View reviewed changes

packages/vscode-extensions/src/browser/vscode-extensions-service.ts Outdated Show resolved Hide resolved

akosyakov reviewed Nov 28, 2019

View reviewed changes

packages/vscode-extensions/src/browser/style/extension-detail.css Outdated Show resolved Hide resolved

akosyakov added the vscode issues related to VSCode compatibility label Nov 29, 2019

akosyakov reviewed Nov 29, 2019

View reviewed changes

jbicker force-pushed the jb/extension-registry branch 2 times, most recently from 96b5ac3 to 42a7f27 Compare December 2, 2019 15:26

akosyakov reviewed Dec 3, 2019

View reviewed changes

packages/vscode-extensions/src/browser/view/detail/vscode-extension-open-handler.ts Outdated Show resolved Hide resolved

jbicker force-pushed the jb/extension-registry branch 4 times, most recently from 4752d5f to cea37e7 Compare December 6, 2019 10:50

vince-fugnitto mentioned this pull request Dec 6, 2019

[enhancement] display the number of 'enabled' plugins #6710

Closed

jbicker mentioned this pull request Dec 12, 2019

[WIP] VS Code missing colors #6722

Merged

77 tasks

akosyakov mentioned this pull request Dec 20, 2019

No delegateCommandHandler for vscode.java.startDebugSession when starting gitpod-io/gitpod#1018

Closed

jbicker force-pushed the jb/extension-registry branch 3 times, most recently from 46143a8 to b82a1c1 Compare January 9, 2020 09:34

akosyakov reviewed Jan 9, 2020

View reviewed changes

packages/vsx-registry/src/browser/vsx-registry-contribution.ts Outdated Show resolved Hide resolved

akosyakov reviewed Jan 9, 2020

View reviewed changes

packages/vsx-registry/src/browser/vsx-registry-service.ts Outdated Show resolved Hide resolved

jbicker force-pushed the jb/extension-registry branch from b82a1c1 to d72e3bd Compare January 10, 2020 09:46

vince-fugnitto mentioned this pull request Jan 21, 2020

Opening the Plugins view using the key bindings does not work initially #6935

Closed

vince-fugnitto added this to the Theia 1.0.0 milestone Feb 4, 2020

spoenemann mentioned this pull request Mar 13, 2020

search returns strange results eclipse/openvsx#31

Closed

akosyakov force-pushed the jb/extension-registry branch 6 times, most recently from 09a6474 to 36b5544 Compare March 13, 2020 16:22

akosyakov added 7 commits March 13, 2020 16:23

[view-container] allow to customize layout

467857c

Signed-off-by: Anton Kosyakov <[email protected]>

[view-container] allow to customize stored state

2142642

Signed-off-by: Anton Kosyakov <[email protected]>

[plugin] remove default vscode extension URI resolver against MS VS C…

adbc0d9

…ode Marketplace Since it's violates MS TOS which allows only access only for products of the VS Code family. Theia based products has to provide own resolution. Signed-off-by: Anton Kosyakov <[email protected]>

[plugin] expose frontend API to access loaded plugins' metadata

f5904ec

Signed-off-by: Anton Kosyakov <[email protected]>

[plugin] add frontend APIs to listen when initial plugins are loaded …

df2f328

…and started Signed-off-by: Anton Kosyakov <[email protected]>

Integration with Open VSX Registry

b7df3c1

Signed-off-by: Anton Kosyakov <[email protected]>

akosyakov force-pushed the jb/extension-registry branch from 36b5544 to b7df3c1 Compare March 13, 2020 16:23

vince-fugnitto reviewed Mar 17, 2020

View reviewed changes

spoenemann approved these changes Mar 18, 2020

View reviewed changes

svenefftinge approved these changes Mar 18, 2020

View reviewed changes

akosyakov merged commit 73bd544 into master Mar 19, 2020

akosyakov deleted the jb/extension-registry branch March 19, 2020 07:35

vzhukovs mentioned this pull request Mar 19, 2020

Adapt changes in che-theia to respect changes in upstream theia eclipse-che/che#16393

Closed

This was referenced Mar 19, 2020

vsx: update display of an extension's readme #7369

Closed

vsx: update styling of extensions in the tree-view #7371

Closed

question: can the 'plugins view' be removed? #7375

Open

vince-fugnitto mentioned this pull request Apr 8, 2020

Add explanation for conceptual decisions theia-ide/theia-apps#340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open VSX Registry integration #6655

Open VSX Registry integration #6655

jbicker commented Nov 28, 2019 •

edited by akosyakov

Loading

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

jbicker commented Nov 28, 2019

akosyakov left a comment

akosyakov commented Dec 12, 2019 •

edited

Loading

akosyakov commented Jan 9, 2020

akosyakov commented Mar 13, 2020

vince-fugnitto left a comment

akosyakov commented Mar 18, 2020

akosyakov commented Mar 18, 2020

vince-fugnitto commented Mar 18, 2020

vince-fugnitto commented Mar 19, 2020

Open VSX Registry integration #6655

Open VSX Registry integration #6655

Conversation

jbicker commented Nov 28, 2019 • edited by akosyakov Loading

What it does

How to test

Review checklist

Reminder for reviewers

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

svenefftinge commented Nov 28, 2019

jbicker commented Nov 28, 2019

akosyakov left a comment

Choose a reason for hiding this comment

akosyakov commented Dec 12, 2019 • edited Loading

akosyakov commented Jan 9, 2020

akosyakov commented Mar 13, 2020

vince-fugnitto left a comment

Choose a reason for hiding this comment

akosyakov commented Mar 18, 2020

akosyakov commented Mar 18, 2020

vince-fugnitto commented Mar 18, 2020

vince-fugnitto commented Mar 19, 2020

jbicker commented Nov 28, 2019 •

edited by akosyakov

Loading

akosyakov commented Dec 12, 2019 •

edited

Loading