-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/ux: styling input validation #12585
ui/ux: styling input validation #12585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should align with vscode regarding the styling of the validation marker:
We need to adjust this:
.theia-settings-container .theia-input[type="number"]:focus {
outline-width: 1px;
}
.dialogContent .error:not(:empty),
.theia-settings-container .pref-content-container .pref-input .pref-input-container .pref-error-notification {
border-width: 1px;
}
Thanks for the feedback Mark, aligning the styling with VS Code makes it look a lot cleaner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Hello, please mention such a breaking modification in the changelog next time. Thanks for the great work! |
reverted DOM structure changes in single text input dialogs. temporary workaround before aligning the validation style in all dialogs Ref: eclipse-theia/theia#12585 Signed-off-by: Akos Kitta <[email protected]>
What it does
This PR fixes #12243 by providing visual feedback for input validation that is consistent with the input validation in the
search-in-workspace
and thepreferences
views. It adds this input validation for theSingleTextInputDialog
to create better feedback for the user.How to test
New File
New Folder
File
->Preferences
->Keyboard Shortcuts
Preferences
andsearch-in-workspace
Preferences Error Validation:
Easy errors to test include: creating a file/folder with no name or a duplicate name, renaming a file to the same name, creating empty key bindings ...
Review checklist
Reminder for reviewers