Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog: provide visual feedback for input validation #12243

Closed
vince-fugnitto opened this issue Feb 28, 2023 · 0 comments · Fixed by #12585
Closed

dialog: provide visual feedback for input validation #12243

vince-fugnitto opened this issue Feb 28, 2023 · 0 comments · Fixed by #12585
Labels
dialogs issues related to dialogs proposal feature proposals (potential future features) ui/ux issues related to user interface / user experience

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The framework provides some nice input validation for the "search in workspace" and "preferences" views. The goal is to provide this experience for the SingleTextInputDialog as well for a consistent look and feel and better feedback.

For example:

image
@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs ui/ux issues related to user interface / user experience proposal feature proposals (potential future features) labels Feb 28, 2023
@vladarama vladarama mentioned this issue May 31, 2023
Merged
1 task
vladarama pushed a commit to vladarama/theia that referenced this issue Jun 21, 2023
Merge branch 'eclipse-theiagh-12243-dialog-input-validation' of https…
4fd58b4 
…://github.com/vladarama/theia into rename-dialogs-maxwidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dialogs issues related to dialogs proposal feature proposals (potential future features) ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui/ux: styling input validation vladarama/theia
1 participant
@vince-fugnitto