Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WS connection for Gitpod #348

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fixed WS connection for Gitpod #348

merged 1 commit into from
Mar 13, 2023

Conversation

spoenemann
Copy link
Contributor

Follow-up of #344

@tortmayr tortmayr self-requested a review March 13, 2023 07:45
tortmayr
tortmayr approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 The random graph example now works as expected in Gitpod

@spoenemann spoenemann merged commit 72cffe9 into eclipse-sprotty:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoenemann @tortmayr