Add separate websocket example #344
Conversation
|
Thanks for the contribution @loganmay! I propose to replace the previous HTTP-based solution because it's very restictive. Could you change the existing example to use your WebSocket-based code? You need to sign the Eclipse Contributor Agreement and sign-off your commit (with |
loganmay
force-pushed
the
add-websocket-example
branch
2 times, most recently
from
cb81757 to
1f762a4
Compare
|
@spoenemann replaced the previous solution, signed the agreement, and signed-off the commit |
Signed-off-by: Logan May <[email protected]>
loganmay
force-pushed
the
add-websocket-example
branch
from
1f762a4 to
cc2b56e
Compare
examples/server/server-app.ts
Outdated
| const diagramServer = new DiagramServer(async (action: Action) => { | ||
| const msg = JSON.stringify({ clientId: incomingMessage.clientId, action }); | ||
| socket.send(msg); | ||
| }, services); |
There was a problem hiding this comment.
Proposal: define the DiagramServer outside the message handler (but inside the connection handler). That way it stays the same server instance as long as the connection remains open, which is relevant in more complex cases where the server might send updates to the client.
Signed-off-by: Logan May <[email protected]>
Signed-off-by: Logan May <[email protected]>
Switch distributed example to websockets