Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate file system tests to JUnit 4 #755

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Migrate file system tests to JUnit 4 #755

merged 2 commits into from
Oct 26, 2023

Commits on Oct 20, 2023

  1. Move utilities from CoreTest to FileSystemHelper 

    The CoreTest class serves as a base class for many tests based on JUnit
3. It provides several file system utilities to its subclasses. These
utilities are, however, not inherent to the test class but can be
provided as independent utilities. This is especially necessary to break
up inheritance hierarchies and foster reuse for JUnit 4/5 migration.

This change moves functionalities concerning symlink creation and temp
file creation to the FileSystemHelper, which is supposed to provide such
functionality.
    @HeikoKlare
    HeikoKlare committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    81afa78 View commit details
    Browse the repository at this point in the history

  2. Migrate file system tests to JUnit 4 

    The FileSystemTest and its subclasses are still based on JUnit 3 due to
implementing the CoreTest class.

This change does the following:
* Migrates FileSystemTest and its subclasses to JUnit 4
* Removes obsolete try/catch blocks by simply making the tests throw the
exceptions or asserting the exceptions
* Adds missing try-with-resources blocks for streams
    @HeikoKlare
    HeikoKlare committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2553ae4 View commit details
    Browse the repository at this point in the history