Migrate file system tests to JUnit 4 #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoreTest class serves as a base class for many tests based on JUnit 3. It provides several file system utilities to its subclasses. These utilities are, however, not inherent to the test class but can be provided as independent utilities. This is especially necessary to break up inheritance hierarchies and foster reuse for JUnit 4/5 migration. This change moves functionalities concerning symlink creation and temp file creation to the FileSystemHelper, which is supposed to provide such functionality.
The FileSystemTest and its subclasses are still based on JUnit 3 due to implementing the CoreTest class. This change does the following: * Migrates FileSystemTest and its subclasses to JUnit 4 * Removes obsolete try/catch blocks by simply making the tests throw the exceptions or asserting the exceptions * Adds missing try-with-resources blocks for streams
HeikoKlare
force-pushed
the
filesystemtest-junit4
branch
from
de3ccbc
to
2553ae4
Compare
akurtakov
approved these changes
Oct 26, 2023
|
Thanks! |
HannesWell
reviewed
Jun 22, 2024
Comment on lines
+116
to
+119
| // The following code creates even a link if | ||
| // Files.createSymbolicLink(new File(basedir, linkName).toPath(), new | ||
| // File(basedir, linkTarget).toPath()); | ||
| // would throw java.nio.file.FileSystemException "missing rights" |
There was a problem hiding this comment.
@HeikoKlare can you tell if this is a common scenario (for tests)?
When looking at the code my fist thought was if Files.createSymbolicLink() can be used.
There was a problem hiding this comment.
@HannesWell Unfortunately, I do not know whether this it is (still) a relevant/common scenario. I have only moved/refactored this code from the CoreTest class without challenging the necessity and way it is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileSystemTestand its subclasses are still based on JUnit 3 due to implementing theCoreTestclass.In addition the
CoreTestclass as a base class for many tests based on JUnit 3, provides several file system utilities to its subclasses. These utilities are, however, not inherent to the test class but can be provided as independent utilities. This is especially necessary to break up inheritance hierarchies and foster reuse for JUnit 4/5 migration.This change does the following:
FileSystemHelperFileSystemTestand its subclasses to JUnit 4