Provide static acessors in the ILog interface as an alternative to Platform #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
move_log_accessor_to_ilog
branch
from
e39cd16
to
be93f2c
Compare
HannesWell
changed the title
HannesWell
reviewed
Jun 14, 2023
There was a problem hiding this comment.
I like the overall idea.
This also reminds me of #33 and I think if we add two new API methods we should add another argument-less convenient method get() or ofContext() or alike.
runtime/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/ILog.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
move_log_accessor_to_ilog
branch
from
be93f2c
to
ee3e05c
Compare
HannesWell
approved these changes
Jun 16, 2023
| @@ -922,7 +922,7 @@ public static long getStateStamp() { | |||
| * @since 3.0 | |||
| */ | |||
| public static ILog getLog(Bundle bundle) { | |||
There was a problem hiding this comment.
I think a comment mentioning the new method would be good here and below.
Eventually this method should at least be deprecated.
| @@ -132,4 +134,45 @@ default void error(String message) { | |||
| default void error(String message, Throwable throwable) { | |||
| log(new Status(IStatus.ERROR, getBundle().getSymbolicName(), message, throwable)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Not it that it really matters, but I have the impression that usually such static factories methods are added at the top of the file instead of the bottom.
|
LGTM |
Currently one obtains ILog either by injection/di or a static call to Platform.getLog(...)., but is is more semantic to only use ILog interface and also decreases the coupling of the code to a central singleton class.
laeubi
force-pushed
the
move_log_accessor_to_ilog
branch
from
ee3e05c
to
1431e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one obtains ILog either by injection/di or a static call to Platform.getLog(...)., but is is more semantic to only use ILog interface and also decreases the coupling of the code to a central singleton class.
This is similar to the recent changes in IPath and will also help in decreasing the need to call
Platform.getXXXmethods so we can easier adapt for changes here especially in the context of eclipse-equinox/equinox#253.A next step would to to replace references, and possibly moving
ILogto equinox common to reduce the amount of split package classes.