Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ILog.of(...) method instead of Platform.getLog(...) #896

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jun 29, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Test Results

     851 files  +     851       851 suites  +851   1h 12m 50s ⏱️ + 1h 12m 50s
  7 202 tests +  7 202    7 044 ✔️ +  7 044  154 💤 +154  3 +3  1 🔥 +1 
22 708 runs  +22 708  22 217 ✔️ +22 217  487 💤 +487  3 +3  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 5cce7b2. ± Comparison against base commit 03b104a.

♻️ This comment has been updated with latest results.

@BeckerWdf
Copy link
Contributor

Can you please explain what is the advantage of "ILog.of" over the current implementation?

@laeubi laeubi merged commit c2521fd into eclipse-platform:master Jun 30, 2023
@laeubi
Copy link
Contributor Author

laeubi commented Jun 30, 2023

Can you please explain what is the advantage of "ILog.of" over the current implementation?

See here for initial change and explanation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants