Remove the use of the C Preprocessor on NASM assembly files #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J9VM_OPT_TEMP_NEW_INTERFACE_INVOCATION is not defined in any build spec, and therefore can be removed from X86PicBuilder with the assumption that it is never defined. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
NASM's preprocessor is capable of handling the ifdef check the C preprocessor was doing. The macro NASM preproceesor will use, ASM_J9VM_INTERP_COMPRESSED_OBJECT_HEADER is defined in jilconsts.inc. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
X86PicBuilder.pnasm and X86Unresolveds.pnasm no longer need to go through the C preprocessor. Also updated the filenames in the makefiles. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
NASM files no longer need to to go through the C Preprocessor. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
nbhuiyan
changed the title
|
@0xdaryl addressed your concerns regarding the never-defined macro, rebased, and did some local testing. Ready for review. |
|
Jenkins test sanity |
|
macOS failure is infrastructure, and the Win32 tests all passed but failed notification (infra issue). I don't see any problems related to this PR. Merging... |
0xdaryl
approved these changes
Oct 12, 2018
0xdaryl
reviewed
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NASM assembly files will no longer need the C Preprocessor. Going forward, there will be no intermediate source files to look at when debugging any of the JIT assembly code. Furthermore, OMR will not need to update its CMake files to handle the temporary
pnasmextention (see eclipse-omr/omr#3042)Depends on: #3237
WIP because of dependency on the PR above which enables writing constants injilconsts.incwith%definedirectives.