Fix JIT on macOS crash in compressedrefs builds #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constants defined using %define directives would enable using them in preprocessor directives. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
X86PicBuilder_nasm.inc uses a constant defined in jilconsts.inc, but it was being included in the wrong order. Also added missing URLs in the copyright header. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
nbhuiyan
changed the title
|
Jenkins test sanity all all |
0xdaryl
approved these changes
Oct 11, 2018
|
CI failure appears to be infrastructural. Remaining CI on non-macOS looks good. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by:
%defineinstead ofequto define constants in jilconsts.incCloses: #3223
Issue: #36
Signed-off-by: Nazim Uddin Bhuiyan [email protected]