Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mosquitto client C++ wrapper to support more MQTT v5 features. #3019

Open
wants to merge 2 commits into
base: fixes
Choose a base branch
from
Open

Improve mosquitto client C++ wrapper to support more MQTT v5 features. #3019

wants to merge 2 commits into from

Conversation

Guy-SE
Copy link

@Guy-SE Guy-SE commented Mar 13, 2024

Please check the following list of things we ask for in your pull request:

  • [*] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [*] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • [*] If you are contributing a bugfix, is your work based off the fixes branch?
  • [*] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [*] Have you successfully run make test with your changes locally?

Those fixes are adding missing mqtt v5 features - mainly properties - in the C++ wrapper mosquittopp.
It is useful for C++ users of the mosquitto client library who want a more complete set of features.

Based on #2823 with some additions - V5 async connect functions.
Thank you @martlaak for the initial PR.

@Guy-SE
Applying changes from Märt Laak <[email protected]> Pull Request e…
b7a99c2 
…clipse-mosquitto#2823 :

    Improve mosquitto client C++ wrapper to support MQTT v5 features

    * create new mosquittopp_v5 C++ wrapper class for that, to maintain backwards compatibility with old code and not to bloat existing wrapper up with too many redundant callbacks
    * make a base class for common code
    * clean up and modernize the code a bit

    Signed-off-by: Märt Laak <[email protected]>
    Signed-off-by: Guy-SE <[email protected]>
@Guy-SE
Add asynchronous versions of connect functions for mqtt V5.
587fc53 
    Signed-off-by: Guy-SE <[email protected]>
@Guy-SE Guy-SE mentioned this pull request Mar 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Guy-SE