Improve mosquitto client C++ wrapper to support more MQTT v5 features #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create new mosquittopp_v5 C++ wrapper class for that, to maintain backwards compatibility with old code and not to bloat existing wrapper up with too many redundant callbacks * make a base class for common code * clean up and modernize the code a bit Signed-off-by: Märt Laak <[email protected]> Signed-off-by: sesa334427 <[email protected]>
Signed-off-by: Gianfranco Costamagna <[email protected]> Signed-off-by: sesa334427 <[email protected]>
Signed-off-by: sesa334427 <[email protected]>
Signed-off-by: sesa334427 <[email protected]>
* Document keepalive=0 is allowed * Remove unused headers * Fix assert failure when loading a persistence file. If the file contains subscriptions with no client id. * Add asynchronous versions of connect functions for mqtt V5. --------- Co-authored-by: Roger A. Light <[email protected]> Co-authored-by: sesa334427 <[email protected]> Signed-off-by: sesa334427 <[email protected]>
This was referenced Feb 27, 2024
|
Closed because the branch was a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?Those fixes are adding missing mqtt v5 features - properties ... - in the C++ wrapper mosquittopp.
It is useful for C++ users of the mosquitto client library who want an up to date set of features.
Based on #2823 with some additions - V5 async connect functions.
Thank you @martlaak for the initial PR.