Move dynamic registration to initialized #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
changed the title
snjeza
approved these changes
Mar 26, 2018
fbricon
reviewed
Mar 26, 2018
| @@ -164,9 +164,70 @@ public void disconnectClient() { | |||
| */ | |||
| @Override | |||
| public void initialized(InitializedParams params) { | |||
There was a problem hiding this comment.
logInfo(">> initialized");
fbricon
reviewed
Mar 26, 2018
| toggleCapability(preferenceManager.getPreferences().isSignatureHelpEnabled(), Preferences.SIGNATURE_HELP_ID, Preferences.TEXT_DOCUMENT_SIGNATURE_HELP, SignatureHelpHandler.createOptions()); | ||
| } | ||
| if (preferenceManager.getClientPreferences().isRenameDynamicRegistrationSupported()) { | ||
| toggleCapability(preferenceManager.getPreferences().isRenameEnabled(), Preferences.RENAME_ID, Preferences.TEXT_DOCUMENT_RENAME, null); |
There was a problem hiding this comment.
if (preferenceManager.getPreferences().isRenameEnabled()) {
registerCapability(Preferences.RENAME_ID, Preferences.TEXT_DOCUMENT_RENAME);
} else {
unregisterCapability(Preferences.RENAME_ID, Preferences.TEXT_DOCUMENT_RENAME);
}should have been removed back in 3c87245#diff-836a9345804342fc811e247515539e98R265
It's replaced by the call to toggleCapability
|
Change looks sound. OK to merge once those 2 comments are addressed |
Moves the dynamic registration of the server capabilities to initialized notification fixes eclipse-jdtls#601 Signed-off-by: Gorkem Ercan <[email protected]>
|
merged as a3fb99c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the dynamic registration of the server capabilities
to initialized notification
fixes #601
Signed-off-by: Gorkem Ercan [email protected]