server is not initialized correctly without configuration call

[gorkem]

Server is not intialized correctly if the client does not send didChangeConfiguration. It is possible that a client does not support settings. Also LSP does not really define an order for the didChangeConfiguration notification. Instead of depending on didChangeConfigration we should use the initialized notification.

[fbricon]

We already do that. See

https://github.com/eclipse/eclipse.jdt.ls/blob/b5f383f45503645baf5f0497bbb37952031bec90/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InitHandler.java#L117-L122

https://github.com/eclipse/eclipse.jdt.ls/wiki/Running-the-JAVA-LS-server-from-the-command-line#initialize-request

[gorkem]

No. If the client reports it supports dynamic registration without this part executing server basically reports that it supports nothing on its capabilities

[puremourning]

I can confirm that i had to put in the didChangeConfiguration event to make jdt.ls start up properly:

https://github.com/Valloric/ycmd/blob/master/ycmd/completers/language_server/language_server_completer.py#L1257

[fbricon]

I see, we assumed didChangeConfiguration requests were sent on startup if dynamic registration is supported, because of vscode's behavior

[puremourning]

I don't think it is a big deal. We'll almost certainly need to support the config stuff at some point anyway.