Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] organize imports #2579 #2871

Closed
wants to merge 1 commit into from

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Aug 29, 2024

@jukzi
Copy link
Contributor Author

jukzi commented Aug 30, 2024

@stephan-herrmann when is a good timepoint to submit this? Its purely the automatic cleanup (takes ~1min). As a second step we could then change the options. If beta branch is different it is possibly simpler to do the same refactoring there instead of solving merge conflicts if any.

@stephan-herrmann
Copy link
Contributor

@stephan-herrmann when is a good timepoint to submit this? Its purely the automatic cleanup (takes ~1min). As a second step we could then change the options.

We should not leave much time between automatic cleanup and changing the options to avoid fresh drift between both actions. My preference: two commits (not-squashed) within one PR.

If beta branch is different it is possibly simpler to do the same refactoring there instead of solving merge conflicts if any.

Generally I'd do such things only when there's only one writable branch. This will be guaranteed once the beta branch has been merged to master (around 17 September)

Alternatively, doing this in the beta branch is an interesting idea, but that would conflict with any other changes between Simrel GA and JDK 23 GA. We don't want to close master until the latter.

Also, the beta branch is under some stress until release, so probably better not to stir up unnecessary dust there right now.

So if you could hold your horses just 3 more weeks that would be safest :)

@stephan-herrmann
Copy link
Contributor

On the positive side #2679 should help avoid that import changes result in warning changes :)

@jukzi jukzi marked this pull request as draft September 5, 2024 11:02
@jukzi
Copy link
Contributor Author

jukzi commented Sep 18, 2024

looks like beta branch has been merged - ready for an update?

@stephan-herrmann
Copy link
Contributor

looks like beta branch has been merged - ready for an update?

indeed so - you're unblocked ...

@jukzi
Copy link
Contributor Author

jukzi commented Sep 30, 2024

superseeded by #3032

@jukzi jukzi closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants