Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 533327 - [9] Implement JEP 211 #2679

Closed
stephan-herrmann opened this issue Jul 5, 2024 · 2 comments · Fixed by #2680
Closed

Bug 533327 - [9] Implement JEP 211 #2679

stephan-herrmann opened this issue Jul 5, 2024 · 2 comments · Fixed by #2680
Assignees
@stephan-herrmann
Milestone
4.33 M2

Comments

@stephan-herrmann
Copy link
Contributor

See https://bugs.eclipse.org/533327 :

Brought to you via http://openjdk.java.net/jeps/211 is this change in JLS §9.6.4.6:
A Java compiler must produce a deprecation warning [...] unless:
[...]
• The use is within an import declaration that imports the ordinarily deprecated
type or member."
@stephan-herrmann
Copy link
Contributor Author

stephan-herrmann commented Jul 5, 2024 •
edited
Loading

Wondering about "ordinarily" in the above I see the JLS has the same import exception regarding "ordinarily deprecated" and "terminally deprecated" (causing otherwise a "removal warning").

So, nothing to worry about, in this regard all deprecation is treated the same.

See https://docs.oracle.com/javase/specs/jls/se22/html/jls-9.html#jls-9.6.4.6

@stephan-herrmann stephan-herrmann self-assigned this Jul 5, 2024
@stephan-herrmann stephan-herrmann added this to the 4.33 M2 milestone Jul 5, 2024
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Jul 5, 2024
@stephan-herrmann
Bug 533327 - [9] Implement JEP 211
4c8df29 
fixes eclipse-jdt#2679
@stephan-herrmann stephan-herrmann mentioned this issue Jul 5, 2024
Merged
@jukzi
Copy link
Contributor

jukzi commented Jul 10, 2024

Thanks for implementing this. Should render @SuppressWarnings at class level for the imports unneeded, allowing more fine grained @SuppressWarnings

rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Jul 18, 2024
@rgrunber
Update target platform to newer 4.33-I-builds (I20240716-1800).
f7768b0 
- Adjust deprecation test due to eclipse-jdt/eclipse.jdt.core#2679
- Ensure Java 17 compliance is used for projects with sealed classes
- core.net fragments merged into host eclipse-platform/eclipse.platform#1440

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber mentioned this issue Jul 18, 2024
Merged
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@stephan-herrmann
Bug 533327 - [9] Implement JEP 211 (eclipse-jdt#2680)
2286ddd 
Don't raise warnings on imports (deprecation, restricted access) 

fixes eclipse-jdt#2679
rgrunber added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Jul 19, 2024
@rgrunber
Update target platform to newer 4.33-I-builds (I20240716-1800).
9ba5c1e 
- Adjust deprecation test due to eclipse-jdt/eclipse.jdt.core#2679
- Ensure Java 17 compliance is used for projects with sealed classes
- core.net fragments merged into host eclipse-platform/eclipse.platform#1440

Signed-off-by: Roland Grunberg <[email protected]>
@stephan-herrmann stephan-herrmann mentioned this issue Aug 30, 2024
Closed
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@stephan-herrmann @gayanper
Bug 533327 - [9] Implement JEP 211 (eclipse-jdt#2680)
6e965e2 
Don't raise warnings on imports (deprecation, restricted access) 

fixes eclipse-jdt#2679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephan-herrmann stephan-herrmann

Labels
None yet
Projects
None yet
Milestone
4.33 M2
Development

Successfully merging a pull request may close this issue.

Bug 533327 - [9] Implement JEP 211 stephan-herrmann/eclipse.jdt.core
2 participants
@stephan-herrmann @jukzi