MSBuild VS 2022 cmakelist suppression of warning 5286 5287 4319#2373
Merged
eboasson merged 2 commits intoeclipse-cyclonedds:releases/0.10.xfrom Mar 23, 2026
Merged
Conversation
eboasson
approved these changes
Mar 23, 2026
Contributor
There was a problem hiding this comment.
@knmcguire This I feel comfortable merging based on the ROS2 CI you linked run. Thanks!
eboasson
merged commit 5041f35
into
eclipse-cyclonedds:releases/0.10.x
1 of 18 checks passed
Author
|
awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resulted from conversation on #2343.
I did a ci build on these changes that you can see here. No MS warnings anymore for MSVC 2022.
This is what it used to be before:
@eboasson would this be more acceptable you think to merge, even if the CI on your end still needs some work?