Fix of enum warnings for MSVC 2022 ROS2 windows rolling build#2343
Closed
knmcguire wants to merge 1 commit intoeclipse-cyclonedds:releases/0.10.xfrom
Closed
Fix of enum warnings for MSVC 2022 ROS2 windows rolling build#2343knmcguire wants to merge 1 commit intoeclipse-cyclonedds:releases/0.10.xfrom
knmcguire wants to merge 1 commit intoeclipse-cyclonedds:releases/0.10.xfrom
Conversation
Generated-by: Claude Code Opus-4.5 (Release 2025/11/01) .
Author
|
We have noticed that this PR together with the master branch of cyclone dds also resolves those warnings. ros2/rmw_cyclonedds#550 I'll close this PR for now, but we can reopen if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is fixing the enum comparison warnings for MSVC 2022 builds for ROS2 on windows (warning C5286 C5287). Cyclone-dds 0.10.x was resulting in over 1500 warnings (See this on the ros2 ci: https://ci.ros2.org/job/test_ci_windows/687/)
With this patch in place, the warnings were resolved (see this test build on ros2 ci).
I'll leave this in draft so that you and the ROS PMC can discuss if this change is desired. An alternative would be to fix this all by all local cmake suppressions of these warnings, but that was a wack-a-mole that required that suppression in a lot of cmake. This was a patch that required the least amount of code change but perhaps not something to be desired.
Related to ros2/ci#832 (comment)
Just let me know what you think.