Replace ssize_t by ddsrt_ssize_t#2339
Closed
eboasson wants to merge 8 commits intoeclipse-cyclonedds:masterfrom
Closed
Replace ssize_t by ddsrt_ssize_t#2339eboasson wants to merge 8 commits intoeclipse-cyclonedds:masterfrom
ssize_t by ddsrt_ssize_t#2339eboasson wants to merge 8 commits intoeclipse-cyclonedds:masterfrom
Conversation
Signed-off-by: Erik Boasson <eb@ilities.com>
No TCP server socket was created if the configured TCP port number is 0, instead of one listening on a random port number. Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
We don't allocate server port numbers like we do with UDP, so adding them makes no sense. Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
There are a number of problems with the TCP implementation that are caused by a bad design. The problems are various: * ownership of connections * handling of disconnects * potential blocking at bad times fixing the requires a wholesale rewrite. It does work reasonably well in somewhat benign settings, and it has on occasion helped save the day. Disabling by default minimises the risk while retaining something that people may have been using. Signed-off-by: Erik Boasson <eb@ilities.com>
This is for compatibility building the Iceoryx plugin on Windows, because Iceoryx uses a different (and I believe incorrect) definition of ssize_t. Signed-off-by: Erik Boasson <eb@ilities.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #2336
This is an alternative to #2340
Building the Iceoryx plugin on Windows fails because Iceoryx brings a different definition of
ssize_t. This introducesddsrt_ssize_tto avoid the collision.The trouble is that
ssize_tis somewhat of an abomination. Hence the alternative PR that eliminates its use in the core code. I'm inviting other people's opinion before deciding which way to go ...