Fix some tcp brokenness#2336
Closed
eboasson wants to merge 7 commits intoeclipse-cyclonedds:masterfrom
Closed
Conversation
eboasson
force-pushed
the
fix-some-tcp-brokenness
branch
from
518c6d6 to
ea2b1f7
Compare
This was referenced Jan 20, 2026
Signed-off-by: Erik Boasson <eb@ilities.com>
No TCP server socket was created if the configured TCP port number is 0, instead of one listening on a random port number. Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
We don't allocate server port numbers like we do with UDP, so adding them makes no sense. Signed-off-by: Erik Boasson <eb@ilities.com>
Signed-off-by: Erik Boasson <eb@ilities.com>
There are a number of problems with the TCP implementation that are caused by a bad design. The problems are various: * ownership of connections * handling of disconnects * potential blocking at bad times fixing the requires a wholesale rewrite. It does work reasonably well in somewhat benign settings, and it has on occasion helped save the day. Disabling by default minimises the risk while retaining something that people may have been using. Signed-off-by: Erik Boasson <eb@ilities.com>
eboasson
force-pushed
the
fix-some-tcp-brokenness
branch
from
ea2b1f7 to
bfda591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... while leaving most of it in place.
The TCP support in Cyclone really never was any good, but it rotted to the point of not working well in various configurations. That is simply too much. This fixes a few things that make it work somewhat, but it doesn't fix the real problems.