Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full-handshake for resumption with empty session id. #846

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

boaks
Copy link
Contributor

@boaks boaks commented Jan 9, 2019

Add no server session id to configuration.
Use creation time for endpoint context, if session id is empty.

Signed-off-by: Achim Kraus [email protected]

Add no server session id to configuration.
Use creation time for endpoint context, if session id is empty.

Signed-off-by: Achim Kraus <[email protected]>
@boaks
Copy link
Contributor Author

boaks commented Jan 9, 2019

#845 for 2.0.x.

If "more" server don't provide a session id than the tradfri gateway, the endpoint context must use something else for matching endpoint contexts

@sbernard31
Copy link
Contributor

LGTM.

So currently, for session without session id, we use the creation time as identifier.
Meaning that 2 sessions which are created as the same time would have the same identifier. A bit strange but probably not an issue as conflict seems really improbable.

Just in case, some idea to replace that :
As resumption and re-negociation are not allowed that means that this session is strongly bound to the connection, so having a kind of connection id would help. (it would also help to implement a real STRICT endpoint context matcher), so we could :

  1. a generate a connection id.
  2. or maybe we could find a kind of connection identifier in DTLSConnectionState ?

@boaks
Copy link
Contributor Author

boaks commented Jan 10, 2019

currently

with cid #824 each connection has a id (unique for a period, so appended with the time, unique), which could then be used. Until yesterday, I didn't even know, that some servers may use empty session id's. So I don't think, this temporary fix will harm.

Otherwise, If you have a lot of time, should we include the cid into M13? :-)

@sbernard31
Copy link
Contributor

I'm OK to integrate it like this.
My comments was just to feed the reflexion for future changes.

So it's good to merge professor ! :p

@boaks
Copy link
Contributor Author

boaks commented Jan 10, 2019

My hint to #824 was, that I hope it's the very near future.

@boaks boaks merged commit a90366c into eclipse-californium:2.0.x Jan 10, 2019
@boaks boaks deleted the empty_session_id branch April 5, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants