Use full-handshake for resumption with empty session id. #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix connection for pending flight to new connection to prevent retransmissions after finishing the handshake. Signed-off-by: Achim Kraus <[email protected]>
|
I spent the afternoon in analyze the behavior of my tradfri gateway when I restart it to reproduce eclipse-archived/smarthome#6065 . I found, the resuming with an "empty session id" is not according I also detected, the the pending flight is maintained by the old connection and so not proper stopped when the next flight of the new connection is sent. This PR fixes both. And I hope it helps to fix smarthome tradfri support. So, if possible, please have a fast check. I think this could be merged soon. If the smarthome project verifies that patch to improve the work, I think we should release 1.0.7 (The 2.0.x PR for the empty session id will come soon.) |
|
LGTM ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix connection for pending flight to new connection to prevent
retransmissions after finishing the handshake.
Signed-off-by: Achim Kraus [email protected]