add lamp warning unicode in html for #142 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw I couldn't figure out the best way to put a full sentence warning message nicely with the way the CSS is currently set, so I am open to suggestions. |
|
opps...forgot to make a separate branch according to github flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Simple & Full html view will now look like:
I felt it important to put the warning unicode next to full brightness. Ideally I would like a text label of message saying something along the lines of: "Warning: LED lamp is very bright and may damage eyes! Be careful to not increase too much!"
Also I changed "Light" to "Lamp" because "Lamp" is more specific. (Maybe "LED Lamp" might be better to, I don't know...or even using the lightbulb unicode symbol.) But mainly I just wanted to get that warning unicode symbol in.