Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that higher LED levels may result in more horizontal static in video mode (and maybe safety warning about brightness of the LED) #142

Closed
ericfont opened this issue Jul 20, 2021 · 9 comments

Comments

@ericfont
Copy link
Contributor

When I use higher LED "Light" brightness settings, I get horizontal static, eg:

image

When I use a moderate LED "Light" brightness, then I get fewer rate of horizontal static, maybe one line every ~5 frames, eg:

image

When I set "Light" to "Off", the I only occasionally can catch a horizontal static line, like here:

image

Though when looking at the feed at "Off" I can only barely notice these occasional horizontal static lines.

And interestingly I am only getting these horizontal static lines while in video mode, but can't seem to find any when using "Get Still", even at highest brightness:

image

I should note that I am USE ESP32-CAM module (with OV2640) and will note that these lines still occur when I using an external board for providing power (rather than than FDTI serial programmer which seems to provide too weak of a signal), and I still get these lines even if I have usb power come directly from wall instead of computer USB hub. I seem to also notice better luck when using slightly thicker power and ground wires, of course cause they have less resistance. I also wonder if fluctuations in the power supply from wifi transmission causes some of these static lines.

Anyway just pointing this out. Though I do think some sortof of warning either in the webpage next to the slider or in the repo's readme would be useful.

@ericfont
Copy link
Contributor Author

I would also recommend putting the following Unicode symbols:
🔆 U+1F506 High Brightness Symbol
⚠️ U+26A0 Warning sign

I'll submit a quick PR for that...would only add 4 bytes to the codebase but might save someone from hurting their eyeballs.

@ericfont
Copy link
Contributor Author

maybe💡(U+1F4A1) might be better cause it stands out more.

@ericfont
Copy link
Contributor Author

Hmm....I'm noticing that the unicode eats up a little bit of the slider horizontal width:

2021-07-20_17-10-brightness-without-unicode

2021-07-20_17-21-wight light unicode warning

Maybe what is better is if ditch the lightbulb unicode, or if have the lightbulb unicode to the left of the word "Light" so it doesn't take up space. Though honestly I feel "LED" or "LED Brightness" might be more informative so it is clear that this slider is not reffering to room brightness or a lightbulb.

What I think I'll just submit a PR with the warning unicode next to full and see if that gets accepted, cause that is most important I think.

@ericfont
Copy link
Contributor Author

I know...I'm looking at view=full versues view=simple, and see that "Quality" in view full takes up two lines, so I think there is space in view=full to have a written warning. I'm also leaning more towards changing "Light" to the more specific "LED Brightness".

@ericfont
Copy link
Contributor Author

I'm looking at the next setting "Auto Lamp" and I'm thinking to make the language consistent, what is called "Light" now should be renamed "Lamp" (or maybe even "Manual Lamp"). I think I'll avoid the word "Brightness" cause that should be reserved for the context of "Brightness"/"Saturation"/"Contrast"

@ericfont
Copy link
Contributor Author

this is how I'll have the simple view:

image

@ericfont
Copy link
Contributor Author

here is my pull request, just adding the warning unicode symbol and changed "Light" to "Lamp": #143

@ericfont
Copy link
Contributor Author

I figured out how to properly do tooltip on the entire div, so I've stetted on a new PR: #148

@ericfont
Copy link
Contributor Author

see #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant