Skip to content

Removed erroneous patch for Intel compiler support in Perl 5.26.0 easyconfig built with GCCcore/6.4.0#5561

Merged
boegel merged 2 commits intoeasybuilders:developfrom
sara-nl:20171220110940_new_pr_Perl5260
Dec 20, 2017
Merged

Removed erroneous patch for Intel compiler support in Perl 5.26.0 easyconfig built with GCCcore/6.4.0#5561
boegel merged 2 commits intoeasybuilders:developfrom
sara-nl:20171220110940_new_pr_Perl5260

Conversation

@jdonners
Copy link
Copy Markdown

(created using eb --new-pr)

@boegel boegel changed the title Removed erroneous patch for Intel compiler support Removed erroneous patch for Intel compiler support in Perl 5.26.0 easyconfig bult with GCCcore/6.4.0 Dec 20, 2017
@boegel boegel changed the title Removed erroneous patch for Intel compiler support in Perl 5.26.0 easyconfig bult with GCCcore/6.4.0 Removed erroneous patch for Intel compiler support in Perl 5.26.0 easyconfig built with GCCcore/6.4.0 Dec 20, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 20, 2017

@jdonners Was this causing problems somehow? Or are you just cleaning it up (also makes sense of course)?

'source_tmpl': 'XML-Bare-%(version)s.tar.gz',
'source_urls': ['https://cpan.metacpan.org/authors/id/C/CO/CODECHILD'],
'checksums': [
'865e198e98d904be1683ef5a53a4948f02dabdacde59fc554a082ffbcc5baefd', # XML-Bare-0.53.tar.gz
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please collapse this to a single line to adher to style used for other easyconfigs (likewise in other easyconfig)

'checksums': ['865e198e98d904be1683ef5a53a4948f02dabdacde59fc554a082ffbcc5baefd'],

@boegel boegel added this to the 3.5.1 milestone Dec 20, 2017
@boegel boegel added the bug fix label Dec 20, 2017
@jdonners
Copy link
Copy Markdown
Author

jdonners commented Dec 20, 2017 via email

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 20, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2572.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e477f678630fe91fc0784758af6c97d6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 20, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2072.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f60dc705ab0c887e7cd66b06425ef268 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 20, 2017

@jdonners Ah, ok, that explains why I didn't see this. In recent GCC(core) installations, there is a symlink for cc, see easybuilders/easybuild-easyblocks#1256

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 20, 2017

Going in, thanks @jdonners!

@boegel boegel merged commit 45bf485 into easybuilders:develop Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants