Skip to content

enhance GCC easyblock to also put symlinks for cc/c++/f77/f95 in place#1256

Merged
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:gcc_symlink_cc
Sep 20, 2017
Merged

enhance GCC easyblock to also put symlinks for cc/c++/f77/f95 in place#1256
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:gcc_symlink_cc

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 19, 2017

fix for #507

@boegel boegel added this to the 3.4.1 milestone Sep 19, 2017
@boegel boegel requested a review from wpoely86 September 19, 2017 20:25
@akesandgren
Copy link
Copy Markdown
Contributor

I would personally not do the chdir in and out, and instead change the symlink to:
symlink(comp_cmd_symlinks[key], target, ... instead. To avoid the basename call and still keep the symlink short-relative

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 20, 2017

Thanks for the suggestion @akesandgren!

Retested, works like a charm:

$ ls -l $EBROOTGCCCORE/bin | egrep ' cc| c\+\+| f77 | f95'
-rwxr-xr-x 4 vsc40023 vsc40023 4566920 Sep 20 15:36 c++
lrwxrwxrwx 1 vsc40023 vsc40023       3 Sep 20 15:36 cc -> gcc
lrwxrwxrwx 1 vsc40023 vsc40023       8 Sep 20 15:36 f77 -> gfortran
lrwxrwxrwx 1 vsc40023 vsc40023       8 Sep 20 15:36 f95 -> gfortran

@akesandgren
Copy link
Copy Markdown
Contributor

old_cmds should be taken from comp_cmd_symlinks and not written twice in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants