Skip to content

disable new rfkill feature in util-linux that requires recent kernel#5480

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:util_linux_no_rfkill
Dec 7, 2017
Merged

disable new rfkill feature in util-linux that requires recent kernel#5480
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:util_linux_no_rfkill

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 6, 2017

Installation of util-linux 2.31 fails on systems with older kernel with:

sys-utils/rfkill.c:67:12: error: 'RFKILL_TYPE_FM' undeclared here (not in a function)
  { .type = RFKILL_TYPE_FM,        .name = "fm",           .desc = "FM" },
            ^~~~~~~~~~~~~~
  CC       sys-utils/setarch.o
make[2]: *** [sys-utils/rfkill-rfkill.o] Error 1

Recent kernel is required for this to work:

$ grep RFKILL_TYPE_FM  /usr/include/linux/rfkill.h
 * @RFKILL_TYPE_FM: switch is on a FM radio device.
        RFKILL_TYPE_FM,
$ rpm -q --whatprovides /usr/include/linux/rfkill.h
kernel-headers-3.10.0-693.5.2.el7.ug.x86_64

rfkill feature (disabling/enabling of wireless devices) is utterly useless in HPC context imho, so OK to disable.

cc @verdurin, @migueldiascosta

@boegel boegel added the bug fix label Dec 6, 2017
@boegel boegel added this to the 3.5.0 milestone Dec 6, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/32bbc58546b58649579d7ffc5cf14bc0 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2029.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/8f951ae1b772ca437218209f2c1f6a4d for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

@verdurin, @migueldiascosta Please test, since both of you ran into this issue?

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 6, 2017

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
rescomp2 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.14
See https://gist.github.com/974e7ffcc1b8737e191408a4f64dbff1 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 6, 2017

@boegel builds fine for me, as you can see.

@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.9, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.6.6
See https://gist.github.com/abc9889d26de78a3d65ceb798af09032 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

@boegel same here

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 7, 2017

@migueldiascosta OK to merge then?

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit ffc89f5 into easybuilders:develop Dec 7, 2017
@boegel boegel deleted the util_linux_no_rfkill branch December 7, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants