Skip to content

{bio}[intel/2017a] BUSCO 1.22 (REVIEW)#5120

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:BUSCO122
Sep 20, 2017
Merged

{bio}[intel/2017a] BUSCO 1.22 (REVIEW)#5120
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:BUSCO122

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Sep 15, 2017 •
edited by boegel
Loading

needs PR #5121

@hajgato hajgato mentioned this pull request Sep 15, 2017
Merged
boegel
boegel requested changes Sep 15, 2017
View reviewed changes
easybuild/easyconfigs/b/BUSCO/BUSCO-1.22-intel-2017a-Python-2.7.13.eb Outdated
postinstallcmds = ['chmod +x %(installdir)s/*.py']

sanity_check_paths = {
'files': ['BUSCO_v1.22.py'],
Copy link
Copy Markdown
Member

@boegel boegel Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato please use %(version)s rather than hardcoding the version?

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel done

easybuild/easyconfigs/b/BUSCO/BUSCO-1.22-intel-2017a-Python-2.7.13.eb Outdated
'dirs': ['sample_data'],
}

modextrapaths = {'PATH': '.'}
Copy link
Copy Markdown
Member

@boegel boegel Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to use '.', '' works fine

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel done

easybuild/easyconfigs/b/BUSCO/BUSCO-1.22-intel-2017a-Python-2.7.13.eb Outdated

toolchain = {'name': 'intel', 'version': '2017a'}


Copy link
Copy Markdown
Member

@boegel boegel Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop duplicate empty line please

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel done

@boegel boegel added this to the 3.4.1 milestone Sep 15, 2017
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 18, 2017

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
ca001.camp.thecrick.org - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2640 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/6b9f8c68f512d65ad31ad691671274b4 for a full test report.

@verdurin verdurin closed this Sep 18, 2017
@verdurin verdurin reopened this Sep 18, 2017
@easybuilders easybuilders deleted a comment from boegelbot Sep 20, 2017
@easybuilders easybuilders deleted a comment from boegelbot Sep 20, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2038.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c889b1567f5a528ae5bb4a898117fd54 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2017

Going in, thanks @hajgato!

@boegel boegel merged commit feb907c into easybuilders:develop Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@hajgato @verdurin @boegel