Use downloaded crates in SnapATAC2-2.9.0#24643
Use downloaded crates in SnapATAC2-2.9.0#24643Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Conversation
|
Test report by @Flamefire |
|
Oh I added offline = False option just in case someone didn't want to cache the crates, so mixing doesn't make sense. |
|
What do you mean by "cache" crates exactly? The 4 cases:
So shall we make the 4th case an error? |
|
Test report by @Flamefire |
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3657125412 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegel Issue fixed by easybuilders/easybuild-easyblocks@e325a7d in easybuilders/easybuild-easyblocks#3993 (part of easybuilders/easybuild-easyblocks#3995) |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Ok, works now with latest fix to easybuilders/easybuild-easyblocks#3995 |
(created using
eb --new-pr)Requires:
Implement mergingenhanceCargo.tomlfile with workspace file easybuild-easyblocks#3988Cargoeasyblock to mergeCargo.tomlfile with workspace file easybuild-easyblocks#4016CargoPythonPackagethe default class for extensions/components ofCargoPythonBundleeasybuild-easyblocks#3993PythonPackageandCargoconfigure step inCargoPythonPackageeasyblock easybuild-easyblocks#3996Can be tested with just easybuilders/easybuild-easyblocks#3993 and easybuilders/easybuild-easyblocks#3995 which includes the other cargo changes
General question: What shall we do when
cratesare given butoffline = Falselike in this case?offline=Falsewe do not add the "source overrides" and the folder where the crates are extracted to is essentially unused as Cargo doesn't know it even existsCARGO_NET_OFFLINEnothing will be downloaded at allOptions:
cratesandoffline=Falseis givenprint_warningonlyofflinebut for crates.io only if there are crates.iocratesset. This allows downloading of e.g. git sources when not given incrates. This allows some flexibility but I don't know if we ever need that or if it would work.