Skip to content

Use downloaded crates in SnapATAC2-2.9.0#24643

Open
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Flamefire:20251121091454_new_pr_SnapATAC2290dev020250630
Open

Use downloaded crates in SnapATAC2-2.9.0#24643
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Flamefire:20251121091454_new_pr_SnapATAC2290dev020250630

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Nov 21, 2025

(created using eb --new-pr)

Requires:

Can be tested with just easybuilders/easybuild-easyblocks#3993 and easybuilders/easybuild-easyblocks#3995 which includes the other cargo changes

General question: What shall we do when crates are given but offline = False like in this case?

  • Currently when offline=False we do not add the "source overrides" and the folder where the crates are extracted to is essentially unused as Cargo doesn't know it even exists
  • If we add the source override, e.g. of crates.io, it will not be able to download anything from crates.io so everything would need to be specified as crates except for git sources
  • If we set the env variable CARGO_NET_OFFLINE nothing will be downloaded at all

Options:

  1. Error out when crates and offline=False is given
  2. print_warning only
  3. Do the overrides independently of offline but for crates.io only if there are crates.io crates set. This allows downloading of e.g. git sources when not given in crates. This allows some flexibility but I don't know if we ever need that or if it would work.

@github-actions github-actions bot added 2024a issues & PRs related to 2024a common toolchains change labels Nov 21, 2025
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3993, easybuilders/easybuild-easyblocks#3995
SUCCESS
Build succeeded for 1 out of 1 (total: 11 mins 18 secs) (1 easyconfigs in total)
i7152 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/aa78e928481c358483d15ad8e07b3251 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 21, 2025

Oh I added offline = False option just in case someone didn't want to cache the crates, so mixing doesn't make sense.

@Flamefire
Copy link
Contributor Author

What do you mean by "cache" crates exactly?

The 4 cases:

  • offline = True && crates: Regular case
  • offline = True && not crates: Just disable download, maybe provided by other means
  • offline = False && not crates: Download during build
  • offline = False && crates: (currently) same as without crates

So shall we make the 4th case an error?

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (total: 13 mins 12 secs) (1 easyconfigs in total)
i7012 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/54ae3be5586d027308daf2c38d4b0d62 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 15, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3995 --installpath /tmp/$USER/pr24632"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=24643 EB_ARGS="--include-easyblocks-from-pr 3995 --installpath /tmp/$USER/pr24632" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_24643 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9184

Test results coming soon (I hope)...

Details

- notification for comment with ID 3657125412 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3995
FAILED
Build succeeded for 0 out of 1 (total: 2 mins 26 secs) (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/f04c178f63f0e152e9521b754d348e8e for a full test report.

@Flamefire
Copy link
Contributor Author

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3995
FAILED
Build succeeded for 0 out of 1 (total: 4 mins 24 secs) (1 easyconfigs in total)
i7029 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/36be888f7badde343eeeb28bd6e9b4f7 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3995
SUCCESS
Build succeeded for 1 out of 1 (total: 13 mins 20 secs) (1 easyconfigs in total)
i7029 - Linux Rocky Linux 9.6, x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.21
See https://gist.github.com/Flamefire/990960500ba7182ba420009b6b02764d for a full test report.

@Flamefire
Copy link
Contributor Author

Ok, works now with latest fix to easybuilders/easybuild-easyblocks#3995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2024a issues & PRs related to 2024a common toolchains bug fix change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants