-
Notifications
You must be signed in to change notification settings - Fork 312
Make CargoPythonPackage the default class for extensions/components of CargoPythonBundle
#3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CargoPythonPackage the default class for extensions/components of CargoPythonBundle
#3993
Conversation
Micket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Note: This currently doesn't change anything because the only difference of CargoPythonPackage to PythonPackage doesn't matter (yet) for Extensions. |
CargoPythonPackage the default class for extensions/components of CargoPythonBundle
|
This needs a small fix so it works with e.g. pymatgen-2023.12.18-foss-2023a.eb and others this updates Proposed fix: Convert |
7964863 to
84b798d
Compare
Actually the issue was attempting to add (in this case no) crates to |
|
That check caused failures because the I updated the easyblock to reset Rebased and removed the change to configure_step that is in #3996 |
…f CargoPythonBundle
We cannot have multiple sources for extensions, see easybuilders/easybuild-framework#3463
74b90af to
e325a7d
Compare
(created using
eb --new-pr)