-
Notifications
You must be signed in to change notification settings - Fork 776
fix Rust sysroot patch to properly skip libraries when setting the interpreter with patchelf #24331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@boegelbot please test @ jsc-zen3 |
|
@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3426796044 processed Message to humans: this is just bookkeeping information for me, |
|
Successful EESSI build (i.e. with non-standard sysroot) in EESSI/software-layer#1249 (comment). |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @bedroge! |
The build of Rust 1.85.1 failed in EESSI (EESSI/software-layer#1249), because of:
This is caused by the existing patch that tries to skip libraries by checking if their filename ends with ".so":
https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/r/Rust/Rust-1.70_sysroot-fix-interpreter.patch#L30
Obviously, that doesn't work for this file named
libLLVM.so.19.1-rust-1.84.0-stable. Instead, I'm now using the approach that Rust's bootstrap script already uses here, i.e. by simply checking if the filename contains.so: https://github.com/rust-lang/rust/blob/master/src/bootstrap/bootstrap.py#L863