-
Notifications
You must be signed in to change notification settings - Fork 776
{tools}[GCCcore/14.2.0] uv v0.7.13 #23143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[GCCcore/14.2.0] uv v0.7.13 #23143
Conversation
Updated software
|
|
Why/How does this fail? I made easybuilders/easybuild-easyblocks#3482 for exactly this use case in my previous PRs of uv. Maybe this is another side of the issue but I'd expect it works.
This is what we cannot do and the reason by this 2nd folder was introduced: Cargo doesn't like workspaces/multi-crates in a vendor folder. We would need to split them up. But using this git-folder approach worked before and is much easier. |
|
It fails with Looking at what we have, there is only a single .cargo-checksum.json at all, and it's inside the there also needs to be something for itself, which is also a crate: Comparing to what though maybe there are multiple valid ways to get it to work. Currently, we are at least one |
|
Test report by @Flamefire |
|
I see, previously we didn't had workspaces with a top-level package. I added support for that to my refactoring PR easybuilders/easybuild-easyblocks#3665 where it was (semi-)easy to support. With that this case works (see above report) |
|
Test report by @Thyre |
|
@Micket Can we un-draft this? |
…asyconfigs into 20250619001459_new_pr_uv0713
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3430627549 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel edit: please ignore, rebuild of Rust was happening (in context of #24331)... |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @Micket! |
(created using
eb --new-pr)Draft because it currently doesn't work.
I'm hitting a problem with the vendored git crates.
It's specifically
pubgrubhttps://github.com/astral-sh/pubgrub which also containsversion-ranges.Cargo easyblock is currently generating the following config.toml:
but in this scenario, the git top-level directory,
pubgrub, itself is also a crate.So, we really need to (also) point to
/dev/shm/uv/0.7.13/GCCcore-14.2.0/easybuild_vendor_git/annoyingly enough.Comparing with cargos own vendoring strategy, it puts
version-rangesandpubgrubinto thevendordirectory directly.I'd like @Flamefire opinion on this.
Depends on: