CI: Don't require setting exts_default_options for single extensions#22490
Closed
Flamefire wants to merge 5 commits intoeasybuilders:developfrom
Closed
CI: Don't require setting exts_default_options for single extensions#22490Flamefire wants to merge 5 commits intoeasybuilders:developfrom
Flamefire wants to merge 5 commits intoeasybuilders:developfrom
Conversation
If there is only a single extension it might make sense to omit `exts_default_options` and set the options directly in the extension.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is only a single extension it might make sense to omit
exts_default_optionsand set the options directly in the extension.See #22422 for an example where this is useful