Fix test failure due to unresolved template#22061
Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom Feb 5, 2025
Merged
Conversation
1 task
Flamefire
force-pushed
the
fix-template-failure-in-test
branch
from
0cb8341 to
97a42e2
Compare
Fixes e.g. File "test/easyconfigs/easyconfigs.py", line 1047, in test_r_libs_site_env_var if 'R_LIBS' in ec['ec'][key]: ... easybuild.tools.build_log.EasyBuildError: 'Failed to resolve all templates in "/path/to/AlphaFold_DBs/%(versions)s" using template dictionary Similar for other changes
Flamefire
force-pushed
the
fix-template-failure-in-test
branch
from
97a42e2 to
aa59f02
Compare
Flamefire
commented
Dec 19, 2024
|
|
||
| for ec in self.parsed_easyconfigs: | ||
| ec_scp = ec['ec'].get_ref('sanity_check_paths') | ||
| ec_scp = ec['ec'].get('sanity_check_paths', resolve=False) |
Contributor
Author
There was a problem hiding this comment.
This and below is from the resolved conflict. Kept it as IMO resolve=False makes the intent clearer
Contributor
Author
boegel
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes e.g.
Similar for other changes
Drive-by fix for
r_libs_ecs.append(ec['spec'])that could append the same EC twice.