Add test for duplicate `PYTHONPATH` in `modextrapaths` by Flamefire · Pull Request #19061 · easybuilders/easybuild-easyconfigs

Flamefire · 2023-10-23T09:19:08Z

And similar test for sanity_check_paths.

Intended to avoid issues fixed in #13385

Edit: Changed to using regexs to catch hard-coded version numbers instead of %(pyshortver)s.

Example failure using one of the faulty ECs from #13385:

CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: sanity_pip_check should be enabled
CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: modextrapaths contains superflous 'lib/python2.7/site-packages' (automatically added by easyblock)
CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: sanity_check_paths['dirs'] contains superflous ['lib/python2.7/site-packages'] (automatically added by easyblock)

Requires:

Fix test failure due to unresolved template #22061
to fix the test failure due to unresolved template

Flamefire · 2024-02-23T12:04:00Z

@boegel Anything missing here? This is a CI test change only so shouldn't cause any regressions for users (but actually helps avoiding them)

Flamefire · 2024-12-19T08:35:18Z

Retargeted 5.0x

boegel · 2025-02-05T12:46:19Z

@Flamefire Sync with 5.0.x now that #22061 is merged?

Flamefire · 2025-02-05T14:50:36Z

Done. Tests pass

Flamefire · 2025-05-08T07:44:09Z

@boegel Rebased this again and extended to checking the resolved values as well as one instance used /lib/python%s...' % local_pyshortver which will now be caught too

Can this be merged before new ECs with those paths get introduced?

boegel · 2025-09-23T18:01:09Z

@Flamefire Needs more love (again), sorry...

Flamefire · 2025-09-24T10:27:24Z

Rebased. Trivial merge conflict after a cleanup of a condition

akesandgren · 2025-10-13T11:34:08Z

test/easyconfigs/easyconfigs.py

+                                     for d in default_dirs if d in extra_python_path)
+            if easyblock == 'PythonBundle' or easyblock.endswith('PythonPackage'):
+                sanity_check_dirs = ec.get('sanity_check_paths', dict()).get('dirs') or []
+                default_dirs = (


Should this use [ and not ( ??

The general guideline I follow is: If the list doesn't need to be modified it will be a tuple

Not sure if this is also faster (due to less capabilities to cater for) but at least it avoids accidental changes where none are intended

But you are modifying it in the with ec.allow... for loop, line 1376

Good catch, not sure how I missed that as it would always fail

akesandgren

LGTM

akesandgren · 2025-10-14T08:56:35Z

@boegel Please check this out. It looks good and clean to me...

akesandgren · 2025-10-15T14:15:05Z

@Flamefire Hmm... I just caused this to have a conflict when merging 21362

Please adjust it

Flamefire · 2025-10-16T07:55:34Z

Rebased and fixed

And similar test for `sanity_check_paths`. Intended to avoid issues fixed in easybuilders#13385

Flamefire mentioned this pull request Oct 23, 2023

Remove duplicated PYTHONPATH module entries #13385

Closed

Micket added the enhancement label Oct 23, 2023

Micket added this to the next release (4.8.2?) milestone Oct 23, 2023

boegel added the tests label Oct 27, 2023

boegel modified the milestones: next release (4.8.2), release after 4.8.2 Oct 27, 2023

boegel modified the milestones: next release (4.9.0), release after 4.9.0 Dec 29, 2023

boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from d45f0b6 to aec46ee Compare April 16, 2024 10:19

boegel modified the milestones: 4.9.2, release after 4.9.2 Jun 8, 2024

boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024

Flamefire changed the base branch from develop to 5.0.x December 19, 2024 08:34

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from 1ef4ac2 to e4fbb9b Compare December 19, 2024 08:34

Flamefire mentioned this pull request Dec 19, 2024

stop using modextrapaths to update $PYTHONPATH with standard path to installed Python packages (lib/python%(pyshortver)s/site-packages) #20960

Merged

1 task

Flamefire mentioned this pull request Jan 20, 2025

Fix test failure due to unresolved template #22061

Merged

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from e4fbb9b to 7e4054b Compare February 5, 2025 13:32

boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025

github-actions bot added change new update workflow labels Mar 20, 2025

github-actions bot removed update workflow labels May 8, 2025

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from f450551 to 2eb7040 Compare May 8, 2025 07:42

boegel modified the milestones: next release (5.1.0), release after 5.1.0 May 23, 2025

boegel modified the milestones: 5.1.1, release after 5.1.1 Jul 5, 2025

boegel modified the milestones: next release (5.1.2), release after 5.1.2 (5.2.0?) Sep 23, 2025

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from 2eb7040 to 8b99903 Compare September 24, 2025 10:26

akesandgren reviewed Oct 13, 2025

View reviewed changes

akesandgren previously approved these changes Oct 14, 2025

View reviewed changes

Flamefire dismissed akesandgren’s stale review via b8b6c2d October 15, 2025 15:55

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from 7ee70db to b8b6c2d Compare October 15, 2025 15:55

Flamefire added 4 commits November 24, 2025 08:54

Add test for duplicate PYTHONPATH in modextrapaths

89d52bb

And similar test for `sanity_check_paths`. Intended to avoid issues fixed in easybuilders#13385

Factor out setting name of EC in failing Python checks

74583bb

Fix type of default_dirs

be9f4f1

Fix linter issues

9fa9549

Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from b8b6c2d to 9fa9549 Compare November 24, 2025 07:58

boegel modified the milestones: next release (5.2.0), release after 5.2.0 Dec 14, 2025

boegel modified the milestones: next release (5.2.1), 5.x Feb 18, 2026

Merge branch 'develop' into add-test-for-duplicate-pythonpath

a2c59e4

Conversation

Flamefire commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flamefire commented Feb 23, 2024

Uh oh!

Flamefire commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel commented Feb 5, 2025

Uh oh!

Flamefire commented Feb 5, 2025

Uh oh!

Flamefire commented May 8, 2025

Uh oh!

boegel commented Sep 23, 2025

Uh oh!

Flamefire commented Sep 24, 2025

Uh oh!

akesandgren Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Flamefire Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

akesandgren Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Flamefire Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

akesandgren left a comment

Choose a reason for hiding this comment

Uh oh!

akesandgren commented Oct 14, 2025

Uh oh!

akesandgren commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flamefire commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Flamefire commented Oct 23, 2023 •

edited

Loading

Flamefire commented Dec 19, 2024 •

edited

Loading

akesandgren commented Oct 15, 2025 •

edited

Loading