Skip to content

fix incompatible types errors when building the R extension dbarts on Arm #20238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 2 commits into from
Mar 30, 2024
Merged

fix incompatible types errors when building the R extension dbarts on Arm #20238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4ccf3a
add -flax-vector-conversions to dbarts compiler flags when building f…
bedroge Mar 28, 2024
1819c2b
add -flax-vector-conversions to dbarts compiler flags when building f…
bedroge Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions easybuild/easyconfigs/r/R-bundle-CRAN/R-bundle-CRAN-2023.12-foss-2023a.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ local_ext_version_check = "pkgver = packageVersion('%(ext_name)s'); if (pkgver !
local_stop_msg = "stop('%(ext_name)s %(ext_version)s not installed, found ', pkgver, ' instead')"
exts_filter = ("R -q --no-save", "%s { %s }" % (local_ext_version_check, local_stop_msg))

# the dbarts extension needs an additional compiler flag on Arm systems to prevent "incompatible types" errors
# cfr. https://github.com/vdorie/dbarts/issues/66
if ARCH == 'aarch64':
local_dbarts_preinstallopts = 'sed -i "s|-c partition_neon.c|-flax-vector-conversions -c partition_neon.c|"'
local_dbarts_preinstallopts += ' src/misc/Makefile && '
else:
local_dbarts_preinstallopts = ''

# !! order of packages is important !!
# packages updated on 10th December 2023
exts_list = [
Expand Down Expand Up @@ -2577,6 +2585,7 @@ exts_list = [
}),
('dbarts', '0.9-25', {
'checksums': ['39a78228ead17c92bd88fe5f959c888412a22a7cbbc0edfa9c09072b4182d870'],
'preinstallopts': local_dbarts_preinstallopts,
}),
('proftools', '0.99-3', {
'checksums': ['e034eb1531af54013143da3e15229e1d4c2260f8eb79c93846014db3bdefb724'],
Expand Down
9 changes: 9 additions & 0 deletions easybuild/easyconfigs/r/R/R-4.2.0-foss-2021b.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ exts_default_options = {
'source_tmpl': '%(name)s_%(version)s.tar.gz',
}

# the dbarts extension needs an additional compiler flag on Arm systems to prevent "incompatible types" errors
# cfr. https://github.com/vdorie/dbarts/issues/66
if ARCH == 'aarch64':
local_dbarts_preinstallopts = 'sed -i "s|-c partition_neon.c|-flax-vector-conversions -c partition_neon.c|"'
local_dbarts_preinstallopts += ' src/misc/Makefile && '
else:
local_dbarts_preinstallopts = ''

# !! order of packages is important !!
# packages updated on 27th April 2022
exts_list = [
Expand Down Expand Up @@ -2796,6 +2804,7 @@ exts_list = [
}),
('dbarts', '0.9-22', {
'checksums': ['68fa2bfe274811c91ea7b67da46c4ffe527eb662d75edbec26ffe934ddc7150a'],
'preinstallopts': local_dbarts_preinstallopts,
}),
('proftools', '0.99-3', {
'checksums': ['e034eb1531af54013143da3e15229e1d4c2260f8eb79c93846014db3bdefb724'],
Expand Down
9 changes: 9 additions & 0 deletions easybuild/easyconfigs/r/R/R-4.2.1-foss-2022a.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ exts_default_options = {
'source_tmpl': '%(name)s_%(version)s.tar.gz',
}

# the dbarts extension needs an additional compiler flag on Arm systems to prevent "incompatible types" errors
# cfr. https://github.com/vdorie/dbarts/issues/66
if ARCH == 'aarch64':
local_dbarts_preinstallopts = 'sed -i "s|-c partition_neon.c|-flax-vector-conversions -c partition_neon.c|"'
local_dbarts_preinstallopts += ' src/misc/Makefile && '
else:
local_dbarts_preinstallopts = ''

# !! order of packages is important !!
# packages updated on 23rd June 2022
exts_list = [
Expand Down Expand Up @@ -2797,6 +2805,7 @@ exts_list = [
}),
('dbarts', '0.9-22', {
'checksums': ['68fa2bfe274811c91ea7b67da46c4ffe527eb662d75edbec26ffe934ddc7150a'],
'preinstallopts': local_dbarts_preinstallopts,
}),
('proftools', '0.99-3', {
'checksums': ['e034eb1531af54013143da3e15229e1d4c2260f8eb79c93846014db3bdefb724'],
Expand Down
9 changes: 9 additions & 0 deletions easybuild/easyconfigs/r/R/R-4.2.2-foss-2022b.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ exts_default_options = {
'source_tmpl': '%(name)s_%(version)s.tar.gz',
}

# the dbarts extension needs an additional compiler flag on Arm systems to prevent "incompatible types" errors
# cfr. https://github.com/vdorie/dbarts/issues/66
if ARCH == 'aarch64':
local_dbarts_preinstallopts = 'sed -i "s|-c partition_neon.c|-flax-vector-conversions -c partition_neon.c|"'
local_dbarts_preinstallopts += ' src/misc/Makefile && '
else:
local_dbarts_preinstallopts = ''

# !! order of packages is important !!
# packages updated on 17th March 2023
exts_list = [
Expand Down Expand Up @@ -2856,6 +2864,7 @@ exts_list = [
}),
('dbarts', '0.9-23', {
'checksums': ['e1ac65fd89c321895d4f0e77d9cd8dcda5f1103485008afd4e19e6c9137557a3'],
'preinstallopts': local_dbarts_preinstallopts,
}),
('proftools', '0.99-3', {
'checksums': ['e034eb1531af54013143da3e15229e1d4c2260f8eb79c93846014db3bdefb724'],
Expand Down