Skip to content

{vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6#16266

Closed
sassy-crick wants to merge 6 commits intoeasybuilders:developfrom
sassy-crick:20220920122025_new_pr_wxPython420
Closed

{vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6#16266
sassy-crick wants to merge 6 commits intoeasybuilders:developfrom
sassy-crick:20220920122025_new_pr_wxPython420

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Sep 20, 2022

@sassy-crick sassy-crick changed the title {vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6 {vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6 WIB Sep 20, 2022
sassy-crick and others added 2 commits September 20, 2022 12:33
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
@sassy-crick sassy-crick changed the title {vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6 WIB {vis}[foss/2021b] wxPython v4.2.0 w/ Python 3.9.6 Sep 20, 2022
@boegel boegel added the update label Oct 20, 2022
@boegel boegel added this to the 4.x milestone Oct 20, 2022
@easybuilders easybuilders deleted a comment from boegelbot Oct 26, 2022
@easybuilders easybuilders deleted a comment from boegelbot Oct 26, 2022
boegel
boegel previously approved these changes Oct 26, 2022
'663cebc4509d7e5d113518865fe274f77f95434c5d57bc386ed58d65ceed86c7', # wxPython-4.2.0.tar.gz
'f13743877deddbf525bbb3f81c8f7a6b0c2dbf1333595926f653f696999e31ce', # wxPython-4.1.1_fix_install_path.patch
],
'sanity_check_paths': {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sassy-crick This is not actually used for extensions, so this should be done differently...

The existing wxPython easyblock should be updated instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for that unusual trick was as this version appears to need attrdict so I switched over to a PythonBundle to add that. It could be at the time I did not realise there is an EasyConfig for attrdict. I have added that as a module now and reverted back to the original build of it. I have also updated the easyblock for it. Thanks for your pointers!

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

Closed as already got a merged version in EasyBuild.

@easybuilders easybuilders deleted a comment from boegelbot Oct 27, 2023
@sassy-crick sassy-crick deleted the 20220920122025_new_pr_wxPython420 branch January 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants