allow unresolved templates in bundle easyblock when handling components#3939
allow unresolved templates in bundle easyblock when handling components#3939Thyre wants to merge 1 commit intoeasybuilders:developfrom
Conversation
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) With a slightly adapted EasyConfig: Click to open |
|
@boegelbot please test @ jsc-zen3 |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3324101885 processed Message to humans: this is just bookkeeping information for me, |
| comp.make_module_step(fake=True) | ||
| # Set fake arg to True, as module components should not try to create their own module | ||
| with comp.cfg.allow_unresolved_templates(): | ||
| comp.make_module_step(fake=True) |
There was a problem hiding this comment.
How can this be correct? If this tries to create a module without being able to resolve templates that unresolved template ends up in the module, doesn't it?
There was a problem hiding this comment.
We probably don't need it in both places, and just having it in the make_module_step should be sufficient. Needs testing though.
The resulting module still looks fine, so this looks like some weirdness with how our Bundle EasyBlock is working.
There was a problem hiding this comment.
Indeed: The result is ignored, so we can just not copy the parent parameters: #3940
|
Superseded by #3940 |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 10 out of 10 (10 easyconfigs in total) |
(created using
eb --new-pr)Fixes regression introduced in #3801, where e.g.
%(installdir)sinmodextravarswas causing an error message like:This can be tested by adding e.g. this to a bundle with at least one component:
Reproducer:
eb ./test.ebworks, but doingeb --rebuild --module-only ./test.ebafterwards fails with the error shown above.With this PR, the installation works and the module looks sane: