change LLVM EasyBlock to not apply concurrency workaround for pre-release LLVM 20#3937
Conversation
|
@Crivella, @Flamefire any objections to this? This certainly would make things easier than trying to break things again, only so that our EasyBlock applies 😅 |
|
I do not have a strong opinion on this. Right now i really do not know how the builder behaves (EG if lit is aware there are multiple instances running and limit itselfs or not) I've never really encountered problems but i've also not done many rebuilds of LLVM since and when i do i always use a limited number of CPUs to avoid memory problems which might be what is saving it. |
|
I haven't encountered any issues at least, though I have noticed that my system is more utilized than it was before that particular change and I rebuilt LLVM more often than I want to admit. However, I never checked the actual CPU usage... |
Crivella
left a comment
There was a problem hiding this comment.
LGTM
the official LLVM does not even have a 20.0 (20.x starts from x=1)
So this would only affect forks of LLVM that version LLVM as 20.0 or 20.0.x
Probably better to work around a failure in applying the patch to the cmake files if it is ever needed
|
Going in, thanks @Thyre! |
(created using
eb --new-pr)Required for ROCm-LLVM 7.0.0 to build, as its using a pre-release LLVM 20, but already includes the required changes.