Skip to content

add explicit enabling/disabling of libffi with custom paths in LLVM easyblock #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocaisa merged 2 commits into from
Jul 25, 2025
Merged

add explicit enabling/disabling of libffi with custom paths in LLVM easyblock #3849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9975a5a
Add explicit enabling/disabling of `libffi` with custom paths
Crivella Jul 16, 2025
e73c102
Fix parameter name
Crivella Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions easybuild/easyblocks/l/llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,12 @@ def configure_step(self):
else:
self.general_opts['LLVM_ENABLE_LIBXML2'] = 'OFF'

libffi_root = get_software_root('libffi')
Copy link
Copy Markdown
Collaborator

@Thyre Thyre Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should've probably checked if libffi is a dependency, right (via self.cfg.dependencies())?
I think the failure in easybuilders/easybuild-easyconfigs#23603 (comment) may well be caused by this change (though I don't know why not on jsc-zen3)

self.general_opts['LLVM_ENABLE_FFI'] = 'ON' if libffi_root else 'OFF'
if libffi_root:
self.general_opts['FFI_INCLUDE_DIR'] = os.path.join(libffi_root, 'include')
self.general_opts['FFI_LIBRARY_DIR'] = os.path.join(libffi_root, 'lib64')

# If 'ON', risk finding a system zlib or zstd leading to including /usr/include as -isystem that can lead
# to errors during compilation of 'offload.tools.kernelreplay' due to the inclusion of LLVMSupport (19.x)
self.general_opts['LLVM_ENABLE_ZLIB'] = 'ON' if get_software_root('zlib') else 'OFF'
Expand Down