add explicit libxml2 and libffi dependencies to LLVM 11.x/12.x/14.x#23603
add explicit libxml2 and libffi dependencies to LLVM 11.x/12.x/14.x#23603boegel merged 4 commits intoeasybuilders:developfrom
libxml2 and libffi dependencies to LLVM 11.x/12.x/14.x#23603Conversation
libxml2 and zstd dependencies to LLVM
|
Going through the LLVM sources, LLVM 15 is the first one adding |
zstd compression was added in LLVM 15 Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3167319735 processed Message to humans: this is just bookkeeping information for me, |
Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
libxml2 and zstd dependencies to LLVMlibxml2 and zstd dependencies to LLVM
libxml2 and zstd dependencies to LLVMlibxml2 and zstd dependencies to LLVM
|
Test report by @boegelbot |
We've seen this test fail before... |
|
Test report by @Flamefire |
All four failed 😕 |
This is weird. Is this an EB bug? Failures are all the same:
libffi gets pulled in through Python during buildtime. I only see |
Maybe because of the options you've set, but I would still expect to see the Gist... Sounds like a bug (or at least oversight) to me
Probably caused by easybuilders/easybuild-easyblocks#3849. So we either need an explicit dependency here, or update the check in the EasyBlock to set that configure option based on |
Both, I'd say. From the log: And there is seemingly an additional place where it might be pulled in in the omptarget plugin: https://github.com/llvm/llvm-project/blob/e64224a224a9891d01ad6eec84921bca1c1f0441/offload/cmake/Modules/LibomptargetGetDependencies.cmake#L42 Hence I guess a dependency is required. |
Signed-off-by: Jan Andre Reuter <jan@zyten.de>
libxml2 and zstd dependencies to LLVMlibxml2 and libffi dependencies to LLVM
While a minimal LLVM should not get to the I updated all the PRs accordingly. For full LLVM builds, |
|
I guess we should still update the easyblock as this seems to be a regression introduced by that change. Could you do that? I could also fold it into the parallel-test PR to reduce testing.
Can you link the related PRs in the description for easier discoverability? |
Agreed, I can look into this tomorrow.
Done |
libxml2 and libffi dependencies to LLVMlibxml2 and libffi dependencies to LLVM 11.x/12.x/14.x
I did a more complete change in easybuilders/easybuild-easyblocks#3881 extending the same logic to all dependencies. This should avoid similar issues. |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3197211400 processed Message to humans: this is just bookkeeping information for me, |
|
Test report from bot was triggered before easybuilders/easybuild-easyblocks#3881 was merged, not sure if that's wise... So, just to make sure: @boegelbot please test @ jsc-zen3 |
|
Test report by @boegelbot |
Hm, looks like |
@Thyre We can try to rebuild |
I'll try a manual rebuild of GCC & LLVM in my home folder at |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3199420047 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Looking at the failure closer again:
Why are we using |
Yeah, that sure is fishy... There's an |
Ah, I understand why... |
|
Test report by @Flamefire |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3225353947 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Going in, thanks @Thyre! |
libxml2 and libffi dependencies to LLVM 11.x/12.x/14.xlibxml2 and libffi dependencies to LLVM 11.x/12.x/14.x
(created using
eb --new-pr)Adding both to all EasyConfigs might be too much for some versions. We can verify this with builds on
jsc-zen3first, and remove things where necessary.Partially resolves #23601
Related PRs: