Use MAGMA option for PyTorch 2+#3683
Open
Flamefire wants to merge 3 commits intoeasybuilders:developfrom
Open
Conversation
jfgrimm
reviewed
May 27, 2025
easybuild/easyblocks/p/pytorch.py
Outdated
| if has_rocm: | ||
| with_gpu_support = True | ||
|
|
||
| if pytorch_version >= 'v1.10.0': |
Member
There was a problem hiding this comment.
is the v in the version intentional? I would have thought that might trip up the version comparison, even with LooseVersion?
Member
There was a problem hiding this comment.
@Flamefire my suspicion was correct:
>>> from easybuild.tools import LooseVersion
>>> v = LooseVersion('2.1.2')
>>> v >= 'v1.10.2'
False
>>> v >= LooseVersion('v1.10.2')
False
>>> v >= '1.10.2'
True
Contributor
Author
There was a problem hiding this comment.
I see. this seems to went unnoticed for quite some time now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)I found that warning while investigating PyTorch 2.6.
This was likely a merge-conflict or oversight while creating #3070 which introduced this:
Reflect this correctly in the code. See their CMakeLists for reference: https://github.com/pytorch/pytorch/blob/40a6710ad34ae4c6f4987f0e47b5c94df3fc8ec7/cmake/Dependencies.cmake#L1692-L1706
Given that this is PyTorch I suggest to just inspect the code and don't do a full test run or at least with
--skip-test-stepas the change is pretty trivial