Skip to content

Force openfoam only use Opt build type #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
appolloford wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Force openfoam only use Opt build type #3591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions easybuild/easyblocks/o/openfoam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,8 @@ def __init__(self, *args, **kwargs):
self.openfoamdir = '-'.join([self.name, '-'.join(self.version.split('-')[:2])])
self.log.debug("openfoamdir: %s" % self.openfoamdir)

# Set build type to requested value
if self.toolchain.options['debug']:
self.build_type = 'Debug'
else:
self.build_type = 'Opt'
# Always set build type to Opt, let easybuild decide CFLAGS and CXXFLAGS
Copy link
Member

@boegel boegel Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't see a need for this, especially in EasyBuild 5.0 where we have a global setting to determine the value of the debug toolchain option (which is disabled by default).

What's the motivation for this exactly?

Copy link
Contributor

@Micket Micket Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        if self.toolchain.options['debug']:
            self.build_type = 'Debug'

is just wrong logic. self.toolchain.options['debug'] means "enable_debug_symbols"

        if self.toolchain.options['noopt']:
            self.build_type = 'Debug'

would be appropriate.

self.build_type = 'Opt'

# determine values for wm_compiler and wm_mplib
comp_fam = self.toolchain.comp_family()
Expand Down
Loading